OpenSolaris

  code review   repo   packages   bugs   defect   polls   planet
You are not signed in. Sign in or register.

6 Integration Procedure

The integration procedure is documented at http://opensolaris.org/os/community/onnv/os_dev_process/.

6.1 Code Review Process

Code review is the ``last defense against brokenness.'' It is a critical part of the development process: no change can be putback by anyone, no matter how knowledgeable or experienced, without first being reviewed. As a version nears release, code review requirements become more strict; more reviewers may be required. The code review process can take anywhere from a few minutes to many hours, depending on the type, size, and intrusiveness of the changes being made. Normally, developers will ask others to review their changes who are familiar with the code being modified.

The purpose of code review is to find subtle and non-obvious problems with the changes being made, not to absolve the implementor of responsibility for his or her changes. Specifically, developers must conduct their own self-review and testing before requesting a formal code review.

6.2 Licensing Requirements

All code integrated into OpenSolaris by a Sun employee must contain the usual Sun copyright notice (see 7.2.3 Non-formatting Considerations). The code will then be licensed by Sun Microsystems both as part of the OpenSolaris project and to other customers via various Solaris and other licenses. Thus, licensing is not a concern for Sun employees.

In order to contribute code to OpenSolaris, developers who are not Sun employees or contractors will need to enter into a contributor agreement. A contributor agreement assures the community that contributors have sufficient rights to the code being contributed, and that any third party intellectual property issues are disclosed. It also allows defense of OpenSolaris should there be a legal dispute regarding the software at some time in the future.

Contributors who add significant changes to an existing file or add new files may include a brief copyright notice similar to the standard Sun copyright notice. See 7.2.3 Non-formatting considerations and the contributor agreement for more information.